search

douban / pymesos

A pure python implementation of Mesos scheduler and executor
BSD 3-Clause "New" or "Revised" License
163 stars 88 forks source link

Add specific timeout for http requests #119

Closed atringham closed 4 years ago

atringham commented 5 years ago

At the moment _timeout is being used as a timeout for http requests as well as a connect deadline. This should be split into two separate timeouts.

A http_timeout for http connections and _timeout should remain for the necessary connect_deadline logic.

My approach would be to add an optional http_timeout in all the necessary __init__ functions and add this whenever we are creating a HTTPConnection. I would default this to DAY to ensure the behaviour would not change by default.

Happy to provide a PR for this if you agree with the approach

ariesdevil commented 5 years ago

Agreed

scrosby commented 4 years ago

When do you think you'll release a new version with this fix?

ariesdevil commented 4 years ago

Done. https://github.com/douban/pymesos/releases/tag/0.3.12