search

douban / pymesos

A pure python implementation of Mesos scheduler and executor
BSD 3-Clause "New" or "Revised" License
163 stars 88 forks source link

Support explicit acknowledgements for status updates #43

Closed bmerry closed 7 years ago

bmerry commented 7 years ago

At present (0.2.7) MesosSchedulerDriver.on_update always calls acknowledgeStatusUpdate, and unlike the old official bindings, there is no option for the scheduler to decide when to acknowledge status updates. This is necessary if, for example, status updates are posted to an asyncio event loop, and will only be fully processed after statusUpdate returns. At the moment I'm working around this by subclassing MesosSchedulerDriver and reimplementing on_update, but that's fragile.

Please provide a constructor argument to allow implicit acknowledgements to be turned off, similar to this.

windreamer commented 7 years ago

yes, we will try to implement this.

windreamer commented 7 years ago

@bmerry would u please help review #44? does it LGTU?