Exclude ZK log replicas entry for Mesos high-availability mode

douban / pymesos

A pure python implementation of Mesos scheduler and executor

BSD 3-Clause "New" or "Revised" License

163 stars 88 forks source link

Exclude ZK log replicas entry for Mesos high-availability mode #5

Closed vshlapakov closed 9 years ago

vshlapakov commented 9 years ago

For Mesos high-availability mode at ZK /mesos path could be an additional entry log_replicas, pymesos detects it as new master node and tries to connect to 0.0.0.0:5050 url as a result. It could lead to an incorrect set of master nodes, and the framework failure.

Some kind of confirmation is here.

The fix adds a simple check for log_replicas entry. Check it please and let me know if I missed smth.

windreamer commented 9 years ago

@vshlapakov thank u for ur PR. I think it would be better if we filter out 'log_replicas' from children.

windreamer commented 9 years ago

@vshlapakov 003688ae should fix this bug, please let me know if sth. is not right.

vshlapakov commented 9 years ago

@windreamer Yeah, it's even better, thanks! :+1: