search

double-great / theme

💅 Jekyll theme for doublegreat.dev
https://doublegreat.dev/theme/
12 stars 3 forks source link

Create custom 404 page #12

Closed jsnmrs closed 2 years ago

jsnmrs commented 4 years ago

It should be very cool, ideally.

jsnmrs commented 2 years ago

@katydecorah Following up on this one — I'm seeing that https://doublegreat.dev/theme/badlink is not showing the custom 404 page that was created in #23.

It could be that 404.html isn't traveling with the theme, so the lack of an explicit 404 in the primary repo means there's not a 404 template at all.

Any ideas?

katydecorah commented 2 years ago

It could be that 404.html isn't traveling with the theme, so the lack of an explicit 404 in the primary repo means there's not a 404 template at all.

I think that's exactly the problem, the 404 doesn't seem to want to travel with the theme.

katydecorah commented 2 years ago

Oh! We might be because we are missing a permalink on the page: https://jekyllrb.com/tutorials/custom-404-page/

I'll PR!