Closed katydecorah closed 4 years ago
I noticed that the favicon was not getting included in the theme. I'm not sure why!
I debugged by running the following commands in the terminal and the favicons were included in the output:
irb print `git ls-files -z`.split("\x0").select { |f| f.match(%r!^(assets|_layouts|_includes|_sass|LICENSE|README|favicon)!i) }
I'm not sure what the deal is! Doesn't seem to like the favicon in the root.
Instead, this PR moves the favicon to the assets folder. I tested this branch locally on the double-great homepage and the favicon was happily included.
I noticed that the favicon was not getting included in the theme. I'm not sure why!
I debugged by running the following commands in the terminal and the favicons were included in the output:
I'm not sure what the deal is! Doesn't seem to like the favicon in the root.
Instead, this PR moves the favicon to the assets folder. I tested this branch locally on the double-great homepage and the favicon was happily included.