Bugfix/#170 show active work instant in report - Githubissues

doubleSlashde / KeepTime

Application to track your time spent on different projects each day.

GNU General Public License v3.0

8 stars 3 forks source link

Bugfix/#170 show active work instant in report #176

Open JonathanWekesser opened 6 months ago

JonathanWekesser commented 6 months ago

Fixed Bug #170
Refactored business logic from UI logic (Report Controller)
added tests for business logic (Report Controller)
active work is added to shown list, when isn't auto-saved yet

sesturm commented 3 months ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 3 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	3
🧪 Relevant tests	Yes
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The logic for adding the active work item to the workItems list in the Report class does not check if the active work item's date matches the report's date. This could lead to incorrect data being displayed for reports not meant for the current date.
	Refactoring Suggestion: The method `fetchWorkItems` in the Report class could be refactored to improve readability and separation of concerns. Consider breaking down the method into smaller, more focused methods.
	Performance Concern: The use of streams and filters in multiple places within the Report class could lead to performance issues with large datasets. Consider optimizing these operations or using more efficient data structures.