search

doubledotlabs / doki

An Android library that displays information from dontkillmyapp.com to users in a clean and presentable manner.
https://jitpack.io/#dev.doubledot/doki
MIT License
169 stars 16 forks source link

Add translation support #3

Open squallsama opened 4 years ago

squallsama commented 4 years ago

Right now there is only English version of instructions available via API. It would be great to have ability to get translated text for different languages. If you need any help, then I would be glad to collaborate.

fennifith commented 4 years ago

I'll point to urbandroid-team/dont-kill-my-app#70 in saying it unfortunately doesn't seem like there are plans to support localization in DKMA (if there were, that would be the place to contribute them). I don't necessarily agree with this response, as I think that even incomplete or out of date translations are better than not having any at all, but I respect their decision. It might be good to bring up the discussion again though, and have a look at how it might be implemented in a way that doesn't require as much support from maintainers.

Anyone is welcome to translate the strings in this repo though, which are a lot less maintenance-heavy (as they're only used on a few buttons and UI elements). The translated file should be strings-[locale].xml in the same directory, or you can just send them to me and I'll put them in. I might actually be able to translate a few of these myself :P

It seems I've been somewhat negligent in documenting the contribution process here; I usually try to place this information in the README when possible. Oops.

squallsama commented 4 years ago

I'll point to urbandroid-team/dont-kill-my-app#70 in saying it unfortunately doesn't seem like there are plans to support localization in DKMA (if there were, that would be the place to contribute them). I don't necessarily agree with this response, as I think that even incomplete or out of date translations are better than not having any at all, but I respect their decision. It might be good to bring up the discussion again though, and have a look at how it might be implemented in a way that doesn't require as much support from maintainers.

Anyone is welcome to translate the strings in this repo though, which are a lot less maintenance-heavy (as they're only used on a few buttons and UI elements). The translated file should be strings-[locale].xml in the same directory, or you can just send them to me and I'll put them in. I might actually be able to translate a few of these myself :P

It seems I've been somewhat negligent in documenting the contribution process here; I usually try to place this information in the README when possible. Oops.

Thanks! Will take a look on string.xml. From my vision it's better to have options in json response related to languages.

Artaud commented 4 years ago

Hey guys, we've currently started work on running the content on DKMA through Google Translate so it will be available through the API machine-translated. Please see https://github.com/urbandroid-team/dont-kill-my-app/issues/19