Closed pepper-jk closed 11 months ago
Just a heads-up, we're collecting different views offline. I agree these need modification.
We have considered these and related changes to the Double Open license categorization and propose the following updates:
As a related change, we will
Happy to hear eventual comments or ideas. Thanks.
This is solved by pull request #43
Hello @willebra,
sorry for not reviewing this earlier. But I finally got around to it.
I like the addition of the property:no-modifications
. Now we can mark both NC
and ND
license accordingly without it effecting the main classification (NC
with property:non-commercial
and ND
with the new property of course).
So you would agree that a CC-N*-SA
license should be copyleft-strong
? Being that copyleft
is the stronger obligation than the other properties.
The other new properties, are good additions as well. We actually have something similar to property:mark-modifications
, so I'm happy to incorporate those changes. Might be able to recontribute something for that later.
However, I noticed two remaining problems regarding CC
licenses in the current main
branch, details below.
I opened a PR https://github.com/doubleopen-project/policy-configuration/pull/49 for this.
CC-BY-NC-SA-2.5
and CC-BY-NC-SA-4.0
are still missing the property:creativecommons
. Therefore they have not been updated at all and remain source-available
.
https://github.com/doubleopen-project/policy-configuration/blob/7a3850dce54333b01e6b59574deac16cd918ee01/license-classifications.yml#L1675-L1685
Same goes for CC-BY-NC-ND-4.0
:
https://github.com/doubleopen-project/policy-configuration/blob/7a3850dce54333b01e6b59574deac16cd918ee01/license-classifications.yml#L1451-L1455
Here we have two more CC
license just missing the property without being classified incorrectly:
https://github.com/doubleopen-project/policy-configuration/blob/7a3850dce54333b01e6b59574deac16cd918ee01/license-classifications.yml#L1438-L1441
https://github.com/doubleopen-project/policy-configuration/blob/7a3850dce54333b01e6b59574deac16cd918ee01/license-classifications.yml#L1486-L1489
The other CC-NC-SA
licenses are still not classified as copyleft-strong
despite being SA
.
https://github.com/doubleopen-project/policy-configuration/blob/7a3850dce54333b01e6b59574deac16cd918ee01/license-classifications.yml#L3358-L3380
Only CC-SA
only licenses appear to be copyleft-strong
:
https://github.com/doubleopen-project/policy-configuration/blob/7a3850dce54333b01e6b59574deac16cd918ee01/license-classifications.yml#L1871-L1881
When I compared our (HELLA's) license classification with yours, I noticed that I moved all
CC-SA
style licenses to becoypleft-strong
, while you have it as eithercopyleft-file-level
orsource-available
. The casecopyleft-file-level
I find less interesting here, as this is not to big a difference. I'm probably just wrong on that one.When I inspected the
source-available
&SA
licenses I noticed, all of them wereCC-SA-NC
. It makes sense to me thatND
licenses would besource-available
, but whyNC
? Is it because the users of your config require commercial use? Or just because scancode classified the licenses like that? [1]Even if the
CC-SA-NC
licenses aresource-available
shouldn't they also becopyleft
due to theSA
clause? I'm curious to hear your opinion.https://github.com/doubleopen-project/policy-configuration/blob/a1252101dbd1422272aece807a3ed3bf693f9c02/license-classifications.yml#L84-L88
https://github.com/doubleopen-project/policy-configuration/blob/a1252101dbd1422272aece807a3ed3bf693f9c02/license-classifications.yml#L1644-L1654
https://github.com/doubleopen-project/policy-configuration/blob/a1252101dbd1422272aece807a3ed3bf693f9c02/license-classifications.yml#L3302-L3321
[1] scancode/cc-by-nc-sa-4.0