search

doubleopen-project / policy-configuration

Double Open license classification for OSS Review Toolkit (ORT) and other uses.
Creative Commons Zero v1.0 Universal
12 stars 5 forks source link

chore: Turn URL comments into properties #65

Open sschuberth opened 7 months ago

sschuberth commented 7 months ago

This is just an idea that I only implemented at a single example to clarify: How does the @doubleopen-project/team think about turning URL comments into properties, so they become machine readable / actionable in rules?

mmurto commented 7 months ago

Excellent idea IMO! Does ORT give errors for license classifications that are used but not defined?

Etsija commented 7 months ago

I also think this is an excellent idea.

sschuberth commented 7 months ago

Does ORT give errors for license classifications that are used but not defined?

Yes, that's why currently the CI check fails. But this actually is a blocker here: We'd not want to define a category for each different URL... not sure how to solve that yet.

mmurto commented 7 months ago

If the check for unknown categories was "relegated" to Evaluator rules from ORT's license classification parsing logic, that would allow only checking for categories that aren't prefixed by url, for example. If possible, a low-friction way could be that the evaluator rules had a default logic that checks for unknown categories as it is know, but it could be overriden in evaluator.rules.kts. Do you think it would be possible?

sschuberth commented 7 months ago

Do you think it would be possible?

It's surely technically possible, but I believe there would be push-back from members of the ORT community for such a breaking change. I'll clarify on that.