search

doubleplusc / Line-sticker-downloader

89 stars 26 forks source link

Cannot download gif stickers #1

Open ccrowles opened 8 years ago

ccrowles commented 8 years ago

First, thank you so much for the work you're doing. Secondly, I've tried downloading a sticker pack that has both animated (not with sounds) and static stickers, and launched the program. The png ones were fine, but the gif ones were all broken. The sticker id is 1322563, if you want to double check. I did all the procedure correctly.

screenshot03314

screenshot03315

Here is one of the converted, not working gifs: 13010894

doubleplusc commented 8 years ago

Hi, Thanks for checking out this program! I've reproduced and found the issue. It's incredibly rare since the site I'm scraping from doesn't necessarily have all the animated stickers available, so the gif downloads for this particular ID failed. It's a good thing you found it, or I would've never known about it!

I can direct the animated sticker downloads to the official Line archives, but they use animated PNGs, which is uncommon compared to animated GIFs and might not be supported in image viewers/editors.

I can push out a fix for the animated sticker downloads sometime this week. However, the animated ones will be in animated PNG format, and if you'll have to convert them to GIFs manually with a converter like apng2gif. I will add support for automatic conversion eventually, but that will have to be when I have more free time.

doubleplusc commented 8 years ago

Hi,

I've implemented a quick fix at https://github.com/doubleplusc/Line-sticker-downloader/releases/tag/0.9.2 Since it's a quick and dirty fix, I won't be closing this issue until I add apng2gif support. But you should be able to get your animated stickers with a little manual work until then.

ccrowles commented 8 years ago

Thank you so much for the fix!