search

doublesecretagency / craft-adwizard

Ad Wizard plugin for Craft CMS
Other
7 stars 8 forks source link

Ad still can be saved without URL #17

Closed piotrpog closed 4 years ago

piotrpog commented 4 years ago

URL field has red * next to URL field that symbolizes that it is required. But we still can save it with this field empty. Ad just wont be displayed in such case.

Maybe make it so that in such case ad would still appear but it would do nothing when clicked?

lindseydiloreto commented 4 years ago

Hmm, this looks like a bug. According to the code, past-me intended for the field to be required normally... it just doesn't seem to be going through a validation process.

As a solution, I am going to simply ensure that there is something validating the URL value. Perhaps I thought Craft itself was handling that part, but it looks like I may need to write it myself.

Thanks for reporting it! 👍

lindseydiloreto commented 4 years ago

Alright, this is fixed for the next release. Thanks again for reporting! 🍺