search

doublesecretagency / craft-googlemaps

Google Maps plugin for Craft CMS - Maps in minutes. Powered by the Google Maps API.
https://plugins.doublesecretagency.com/google-maps/
Other
10 stars 9 forks source link

🚩 Improve Matrix compatibility #1

Closed lindseydiloreto closed 3 years ago

lindseydiloreto commented 3 years ago

At launch, the Google Maps plugin will have partial (read: buggy) support for Address-in-Matrix fields.

This is obviously a critical component, so completing this feature is our highest priority.

zizther commented 3 years ago

Look forward to moving to this plugin once this issue is sorted, as the project in mind has this requirement.

damienbuckley commented 3 years ago

Any progress with this? Address field works fine in an entry but doesn't show up at all in a matrix block.

lindseydiloreto commented 3 years ago

@damienbuckley Still extremely high on our radar. Sorry for the delay.

Our realistic ETA is about 7 - 10 days from now. If you haven't heard from me by then, feel free to check back. 👍

damienbuckley commented 3 years ago

Great stuff!

darinlarimore commented 3 years ago

I believe I'm experiencing this issue too. I'm able to pull the data from the address fields but they do not show when editing the entry like your encounter @damienbuckley. Also possibly related, I receive this TypeError when attempting to edit the field here admin/settings/fields

TypeError Argument 1 passed to craft\services\Fields::getGroupById() must be of the type int, null given, called in .../vendor/craftcms/cms/src/base/Field.php on line 565

lindseydiloreto commented 3 years ago

Good news everyone, this is done! 🎉

As of v4.0.4, the Google Maps plugin is now fully compatible with Matrix, Neo, and Super Table.

lindseydiloreto commented 3 years ago

@darinlarimore Try updating to the latest and give it another shot. If you're still seeing issues after that, feel free to DM me or start a new thread. 👍

lindseydiloreto commented 3 years ago

Just FYI, I've added a new page to the docs on how to use an Address in a Matrix Field.

darinlarimore commented 3 years ago

Thank you! I can confirm this is working for me now! @lindseydiloreto

lindseydiloreto commented 3 years ago

Excellent, thanks for the update @darinlarimore!