search

doublesecretagency / craft-googlemaps

Google Maps plugin for Craft CMS - Maps in minutes. Powered by the Google Maps API.
https://plugins.doublesecretagency.com/google-maps/
Other
10 stars 9 forks source link

Rsync error during production. #63

Closed krisMoca closed 1 year ago

krisMoca commented 2 years ago

We are having this rsync error when pushing our code base to our production server. image

trying to open the file locally and it showing a FileSystemError message. image

image

What's the best way to solve this issue?

lindseydiloreto commented 2 years ago

Well that's... interesting. Looks like a relic from my attempt to implement Codeception. You'll notice I didn't get very far.

That particular file is a symlink. But it's not being used at all, so it's probably safe to just delete it. Go into the vendor folder and just delete it for now. Once you've deleted the file, I believe rsync should work as intended.

I'll circle back soon and remove it from the repo. That symlink isn't currently serving a purpose, I may as well delete it until I'm ready to give Codeception another shot.

lindseydiloreto commented 1 year ago

This symlink has been removed. The fix will be included in the next release (v4.2.6).

Thanks for reporting it! 👍

justinmacleod commented 1 year ago

@lindseydiloreto We just encountered this issue with a CodeDeploy deployment using your plugin. I see that 4.2.6 hasn't been tagged yet. Can you tag that release so we can properly upgrade? For now, I'll exclude the file when pushing to CodeDeploy. Thanks!

lindseydiloreto commented 1 year ago

Hi @justinmacleod,

That release is still waiting for a few other things to be completed. To get the latest dev version (including the fix for this ticket), just change the composer package version to this...

"doublesecretagency/craft-googlemaps": "dev-v4-dev"

... then run composer update.

Hope that helps!

lindseydiloreto commented 1 year ago

This fix has been officially released in v4.3. 👍