Unable to render plugin on page if Geolocation Service set to none

doublesecretagency / craft-googlemaps

Google Maps plugin for Craft CMS - Maps in minutes. Powered by the Google Maps API.

https://plugins.doublesecretagency.com/google-maps/

Other

10 stars 9 forks source link

Unable to render plugin on page if Geolocation Service set to none #72

Closed T-Ivings closed 1 year ago

T-Ivings commented 1 year ago

In our CMS, we have our Geolocation Service set to none. We get the following error if we try to view the page using the plugin.

TypeError
doublesecretagency\googlemaps\helpers\GeolocationHelper::_getApiModel(): 
Argument #1 ($selected) must be of type string, null given, called in 
/srv/redacted/vendor/doublesecretagency/craft-googlemaps/src/helpers/GeolocationHelper.php on line 47

It functions properly for us if we change the service to ipstack and leave the API blank.

lindseydiloreto commented 1 year ago

Interesting, that definitely sounds like a bug. Thanks for reporting it! 👍

Let me dig in and I'll let you know what I find.

lindseydiloreto commented 1 year ago

This is fixed, and will be available in the next release. Thanks for filing this issue! 🍺

If you'd like to get the latest dev version now, change your composer.json file to say...

"doublesecretagency/craft-googlemaps": "dev-v4-dev"

... and then run composer update.

lindseydiloreto commented 1 year ago

This patch has been officially released in v4.3. 👍