search

doublesecretagency / craft-starratings

Star Ratings plugin for Craft CMS
Other
4 stars 3 forks source link

Enabling GraphQL support duplicates entries in CP index views four times #27

Open howells opened 2 years ago

howells commented 2 years ago

A strange one: when I enable Star Rating's GraphQL (I really need to grab an entry's total votes via GQL), it has the strange effect of duplicating the number of times an entry is shown on a section that has star ratings enabled by a factor of 4.

Without GraphQL enabled:

CleanShot 2022-09-23 at 17 23 45@2x

With GraphQL enabled:

CleanShot 2022-09-23 at 17 21 04@2x

Any ideas why that would be?

lindseydiloreto commented 2 years ago

Interesting, that's not ideal. I may have seen that issue before, which is part of why GraphQL support is still in beta.

In order for the GraphQL stuff to work, Star Ratings gets involved in Craft's element query on a very deep level. It's a very heavy-handed way to get the GraphQL stuff to behave as necessary. I don't love the implementation, but it's the best we could do at the time.

In the long-term, I'll fix it before GraphQL support graduates from beta. I'm not sure exactly when that will be, but it probably won't be anytime soon. My apologies, we have a handful of higher priorities at this moment.

In the short-term, could you potentially disable the GraphQL support while you make content changes?

howells commented 2 years ago

@lindseydiloreto if it were my own project I'd be happy to disable it while making changes but I wouldn't be able to get my client to do that. Can you think of any way I could get around it... do you think I could use a preparse field somehow to calculate on save? Just means I'll have to periodically resave the entries.