Open LukeFranceschini opened 9 years ago
I'm not opposed to this idea, but I'm not sure where you'd find the space for it.
thoughts on just adding to hover? Even though hovers need to be dealt with for mobile friendly...
Ignore my wrong math, it was right for the first screen shot and then there was an attack. My village will never be the same :( moment of silence for my lost wanderers.
That was actually a feature on my list that I never got around to (and then promptly forgot about).
On 27 October 2014 14:19, Blake Grotewold notifications@github.com wrote:
thoughts on just adding to hover? Even though hovers need to be dealt with for mobile friendly...
[image: old] https://cloud.githubusercontent.com/assets/1421810/4796726/9394af02-5e05-11e4-9216-3aab44f44817.png [image: new] https://cloud.githubusercontent.com/assets/1421810/4796725/9393b034-5e05-11e4-9648-b49898c600ec.png
Ignore my wrong math, it was right for the first screen shot and then there was an attack. My village will never be the same :( moment of silence for my lost wanderers.
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-60642659 .
moments of silence? :stuck_out_tongue_winking_eye:
ADR is one long, agonizingly deafening moment of silence.
On 27 October 2014 14:23, Blake Grotewold notifications@github.com wrote:
moments of silence? [image: :stuck_out_tongue_winking_eye:]
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-60643617 .
that's deep, man...
Thank you for your bounty! You heard him, folks, may the best PR win!!!
Perhaps in the "stores" on the right:
(made up numbers obviously)
Something like that might work, but I think we'd need to differentiate the delta from the total somehow. Also, we need to consider how the alignment will look with different numbers of digits for each resource.
On 31 October 2014 13:16, Warren Konkel notifications@github.com wrote:
Perhaps in the "store" on the right:
[image: image] https://cloud.githubusercontent.com/assets/26543/4865101/98fc5066-6121-11e4-8475-b0b6e3872e91.png
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-61294936 .
I got total up on tooltips. The delta on the stores container is quite a bit tougher but my idea about splitting it from the quantity is to make that delta a fixed width column. Expectedly no delta could be higher than 5 digits so with 50px, all widths would be covered. Additionally we could use
±
html entity for ±0s to keep a symbol in front consistency.
Got the delta working, not sure if I like the plus or minus
symbol, seems like a lot. IMO we have three options
plus or minus symbol
plus symbol
no symbol
Let me know your thoughts. Maybe it is better without?
My concern with this layout in general is that the quantity column for the stores panel no longer lines up with the quantity column for the other sections (weapons, village, etc...). This is kind of visually confusing, not to mention a little dense.
On 31 October 2014 15:27, Blake Grotewold notifications@github.com wrote:
Got the delta working, not sure if I like the plus or minus symbol, seems like a lot. IMO we have three options
plus or minus symbol [image: croppercapture 5] https://cloud.githubusercontent.com/assets/1421810/4867291/ae843176-6133-11e4-84d6-f6c0b857f1ab.png
plus symbol [image: croppercapture 6] https://cloud.githubusercontent.com/assets/1421810/4867266/5fae96b8-6133-11e4-94b2-d0fe995b36fc.png
no symbol [image: croppercapture 7] https://cloud.githubusercontent.com/assets/1421810/4867292/b0bb3c3c-6133-11e4-8d2e-49b153e1c5af.png
Let me know your thoughts.
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-61316517 .
yeah my only thought to combat that problem is to hide it, except on hover, Which feels redundant but would effectively fix that issue. Another idea I had was to put a Δ button at the top of stores that would change all values to their delta amounts.on hover.
example of hiding except on hover
If these feel super redundant maybe it's not worth adding except in tooltip.
yes do that great idea
Just my 2 cents...
I'm not a fan of the animations in "example of hiding except on hover". The hover state is great as it shows where the total comes from. What about hover text and also a column of gray text on the left instead of the right:
This is a promising avenue of investigation.
On 3 November 2014 13:42, Warren Konkel notifications@github.com wrote:
Just my 2 cents...
I'm not a fan of the animations in "example of hiding except on hover". The hover state is great as it shows where the total comes from. What about:
What about a column of gray text on the left instead of the right:
[image: image] https://cloud.githubusercontent.com/assets/26543/4887944/18dad492-6389-11e4-932e-78d72db7f100.png
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-61526041 .
I like the idea but it reminded me that all these 3rd column options have an issue with the width of the max item limit 112px. See cured meat
example below.
If we want this third column, we have a couple options off hand. One option is increase the width of the stores/weapons/village/perks boxes. Below is an example of 230px.
Option two is to have the middle delta column not line up with itself but instead pad it away from the amount of the item. See example below. NOTE that the width issue still exists so not really an option.
We could also reduce the maximum width of the quantity column by replacing large numbers with a placeholder (like "> 99999" or something)
On 3 November 2014 15:01, Blake Grotewold notifications@github.com wrote:
I like the idea but it reminded me that all these 3rd column options have an issue with the width of the max item limit 112px. See cured meat example below. [image: croppercapture 8] https://cloud.githubusercontent.com/assets/1421810/4888633/b3827252-638e-11e4-8427-0aa6b2754fb8.png
If we want this third column, we have a couple options off hand. One option is increase the width of the stores/weapons/village/perks boxes. Below is an example of 230px. [image: croppercapture 10] https://cloud.githubusercontent.com/assets/1421810/4889183/aa5c67be-6393-11e4-90ed-470d3a92b1f8.png
Option two is to have the middle delta column not line up with itself but instead pad it away from the amount of the item. See example below. NOTE that the width issue still exists.
[image: croppercapture 11] https://cloud.githubusercontent.com/assets/1421810/4889264/27753910-6394-11e4-8ee7-9e234b6bc9dc.png
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-61538848 .
I am definitely more inclined towards having the numbers line up, and having them closer to the names of the materials. This allows you to more easily take in all the information at a glance. It's also nice to have the delta closer to the material names because I am often more interested in the balance of materials than what my absolute totals are. The "> 99999" idea sounds useful, as I don't think many people would actually end up having 99999999999999 of an item. One thing to ponder is if we should just cap it at 99999 instead of allowing it to be larger than that, so that there will never be any unknown information. If I saw "> 99999", I would want to be able to find out how much greater than 99999 it is, and we would have another issue of trying to fit more information into that little box.
You could use a descriptive label, like "abundant", "innumerable", "almost infinite" or "too much to count". That way people might feel less inclined to complain.
I think it's okay to have it wrap to a new line when dealing with numbers like 99999999999999. If it becomes an issue down the line, somebody will create a new issue and it can be dealt with then?
I strongly disagree. Line wrapping will look bad. Let's get this right the first time.
On 4 November 2014 12:07, Warren Konkel notifications@github.com wrote:
I think it's okay to have it wrap to a new line when dealing with numbers like 99999999999999. If it becomes an issue down the line, somebody will create a new issue and it can be dealt with then?
— Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/170#issuecomment-61675977 .
My current plan is to support 1,000,000 or less. anything more will simply state '> 1000000'. In the tooltip we could state the total the amount, but it may not fit.
Seeing as anything more for wood would take ~7 hours to deplete with 80 charcutiers going (assuming you have equal amounts meat and wood).
ok do you want me to fix it?
Is this idea still worked upon? I liked the tooltip solution for its clean design, in line with current use for tooltips. Hiding the delta and showing it on hover has the same usability issues without solving width problem. Adding a column could be troublesome also because in other languages some items could have longer names, apart from the quantity issue (I'd say that absolute quantity should be shown in its actual value, it's easier to evaluate even if the number is high, thanks to alignment with other quantities).
EDIT: what about a selector below store box? There could be 2 commands, "stock" and "flow", and clicking on either one will switch between absolute values, and relative flows (with sign and ±0 where necessary) as "row value"
Still no delta.. I think it makes sense going in as last row in the tooltip. That's where the calculation is, that's where users currently look for this exact information.
I could make it my first github contribution and my very first pull request (obviously not my first lines in js though)
Please do! While it seems redundant. Please keep it in context of the time as well, doing the calculation of the average time between the rows. (Should remain 10 but keeps the system ready for change)
On Wed, Jul 29, 2015 at 7:18 AM, Sebring notifications@github.com wrote:
Still no delta.. I think it makes sense going in as last row in the tooltip. That's where the calculation is, that's where users currently look for this exact information. I could make it my first github contribution and my very first pull request (obviously not my first lines in js though)
Reply to this email directly or view it on GitHub: https://github.com/doublespeakgames/adarkroom/issues/170#issuecomment-125922129
Ok, cool!
I was thinking of not adding time context to the label, as shown in the screenshot above. It makes it very quick and easy to catch the total value on quick glances.
The calculation itself, however, includes the income delay and will not break if it's changed.
Sounds good?
Also, about localisation, this will add a new string total
. I'm not very confident with all the Poedit stuff, is there something more I need to do (in terms of localisation) than to use _('total')
for the tooltip label?
For now just do the _('total')
and we'll get the .pot file updated
cc. @AndySky21 (you've done this before, got another commit in you? :stuck_out_tongue_closed_eyes: )
This is completed and can be closed
It would be nice if there was a "Delta" section on the stores section that allowed you to see how many supplies/10s you are created or consuming. This would allow you to see all the information at a glance instead of trying to do the mental math while hovering over each worker type while on the village tab. My first thought would be to have a +5 or -2 beside each item type (unless it's delta was 0). If this sounds like a good idea to you, I can help with the implementation of it as well, I just want to test the waters before diving right in.
I'm not sure how to mark this as an enhancement (or if I'm even able to), help with that would be appreciated!