Possible changes

[AndySky21]

I have found a version of ADR I had modified some months ago, and I'd like to propose the changes I made, along with other minor changes/fixes I'd like to work on. This post is both a to-do list and a way to see if the changes are desirable, so feedback is appreciated.

Fixes:

• [x] #459: the supplies issues could be solved by removing them from the total stores count
• [x] #452: supplies reset on return rather than on embark
• [x] This is a bug I have to test again: after completing some locations, before the final success panel ("The mine is now safe"), the "take everything" button incorrectly says "and leave" too (it does not actually leave, though).
• [x] I have to test this as well. The Scout event allows players to buy a map, even if everything is explored. And remember that, during an event, one does not simply walk into Mord... er, the World and see if they explored everything.
• [x] Stores with number = 0 do not disappear from store box, but they're not shown on game reload until number becomes positive again. I'd force consistency (let stores appear in box as far as the name is present in state, no matter the value)
• [x] Italian translation of my own event notifications. Yes, it was me who wrote some of them in english. Yes, I forgot to translate them into my language. I'll probably have to update the pot file, too.

Improvements (some of them are ready, in a messy file):

• [ ] Loot "briefing" on Path tab in case of successful return (so the players can see what they gained and what they lost)
• [ ] Stores divided in "things which can be produced" (even if they are not being currently produced) and "things which must be retrieved/purchased", to better control village economy. Produced goods will have a little switch to toggle visualisation between "total store" and "net flow" (I'm an economist after all).
• [ ] Supplies organically divided in weapons (and corresponding ammo) and other stuff.
• [x] Heal buttons separated from attack buttons during fights, and from loot/scene buttons after fights. This will prevent them from change position when retrieving new weapons.
• [x] Disabling heal buttons when health is max. This will prevent players to click too many times (I did it often at the beginning, thus losing units of meat and meds)
• [x] A pause button during fights.

Long-term improvements

• [ ] Vertical scroll revision: as now side columns are quite long, I'd like to change the custom vertical scroll (I also suppose that not many players know they can scroll side boxes with up and down keys) and enable native full-height scroll (while leaving in place everything else).
• [ ] State shortening (does not need more words, I guess).

[groteworld]

God-like contributions again @AndySky21. It will be a couple weeks before I'm fully through all these. :smile: Thanks!

[AndySky21]

Take all the time to test, I'll try to make them as flawless and conflict-free as I can, even if some of them do involve the same files unfortunately. Glad to contribute to such a great project, though.

[gitupofftheflooranddosomework]

Close, all merged and the one that is open is not an issue

[esaruoho]

@AndySky21 could you close this ticket, please?