doublespeakgames / adarkroom

A Dark Room - A Minimalist Text Adventure
Mozilla Public License 2.0
7.21k stars 1.6k forks source link

CSS error #571

Open keybounce opened 7 years ago

keybounce commented 7 years ago

In the outside world map, the css for body -> wrapper -> content has "overflow: hidden". Disabling that with firebug makes the whole map visible / playable.

keybounce commented 7 years ago

EDIT: Or not. It took both that, and ... hmm. Can't find it now, but it's an interaction of at least two things.

keybounce commented 7 years ago

So the bottom line: I have to keep editing the CSS. I cannot see the whole world map without ultra-tiny text, and eventually I reach the point where it's so messed up I have to reload.

Basic core issue: I can see at best half of the worldmap before the text is too small to read. If I make the whole thing visible and scrollable, then notifications appear off the top of the map, making the battle a pain -- so the bottom half of the map is really hard to explore.

The solution would be to make the map scrollable, and have the notifications appear on-screen. I don't know CSS well enough to do that -- perhaps the map inside a scrollable sub-frame and the notifications appearing in the top?

AndySky21 commented 7 years ago

The map tab is the one which needs more attention. Having it scrollable requires JS to freeze scrolling when player uses arrow keys. However, menu bar and sometimes also inventory bar above cover some of the map.

The solutions, that are not meant as alternatives, are these:

  1. Make inventory more compact: maybe just water and food while walking, unless hitting an "expand" button to see all.
  2. Make menu bar hidable, with a button to expand it (that would apply to all tabs, but on world it should be hidden by default).
  3. Make the map zoomable, so that you can switch between "full map mode" and "close view mode". Close view would be, say, a 10x10 square centered on the player (unless the player is nearer to a border), and it would give no problem at pretty any resolution.
gitupofftheflooranddosomework commented 6 years ago

this is fixed in the above code, please close