search

doublespeakgames / adarkroom

A Dark Room - A Minimalist Text Adventure
Mozilla Public License 2.0
7.31k stars 1.62k forks source link

When attacking, only the first two sounds of each weapon type are used, not the third #699

Open avengah opened 2 years ago

avengah commented 2 years ago

https://github.com/doublespeakgames/adarkroom/blob/48ece588ed65e3c1c412ee57143ef447185cd0c9/script/events.js#L425

The problem here is that this expression can only produce 1 or 2, not 3. It should be changed to 3 instead of 2, to use all three variations of each weapon sound.

avengah commented 8 months ago

The line in question appears twice in events.js, once for the player's attack and once for the enemy's attack, which I missed last time. Still, it hasn't been fixed yet.