search

doublespeakgames / adarkroom

A Dark Room - A Minimalist Text Adventure
Mozilla Public License 2.0
7.32k stars 1.62k forks source link

Syntax error in engine.js #72

Closed mehbleh closed 10 years ago

mehbleh commented 10 years ago

When I bring up the console, it says there's a syntax error on line 129 of engine.js which is in the section for adding the button to the App store. So, I downloaded a copy of the web page and associated files. I thought it might be a missing closing single quote and closing bracket on line 128 but, adding it before the --> didn't seem to fix anything. My knowledge of Javascript is rather weak, so I'm not sure what the problem is.

Not sure if these are needed or anything. Screenshot of console: screen1

Screenshot of problem section: screen2

Edit1: What I see in the production version of A Dark Room is different from what is currently in Github. Not sure if that's why.

Continuities commented 10 years ago

Line 128 isn't actually the code as I wrote it. I'm guessing that you have an addon that is trying to inject itself and failing badly. Try disabling your addons and reloading. I'm betting the error will go away.

Cheers,

On Friday, December 27, 2013, mehbleh wrote:

When I bring up the console, it says there's a syntax error on line 129 of engine.js which is in the section for adding the button to the App store. So, I downloaded a copy of the web page and associated files. I thought it might be a missing closing single quote and closing bracket on line 128 but, adding it before the --> didn't seem to fix anything. My knowledge of Javascript is rather weak, so I'm not sure what the problem is.

Not sure if these are needed or anything. Screenshot of console: [image: screen1]https://f.cloud.github.com/assets/6272745/1816111/0ab95184-6f30-11e3-9501-becae43877a0.PNG

Screenshot of problem section: [image: screen2]https://f.cloud.github.com/assets/6272745/1816117/3a999ecc-6f30-11e3-84c6-a3ac3d2801bc.PNG

— Reply to this email directly or view it on GitHubhttps://github.com/Continuities/adarkroom/issues/72 .

mehbleh commented 10 years ago

Thanks for the quick reply. I've disabled all add-ons and cleared cache on Firefox, Chrome, and IE. Same garbled line appears. Might just be some problem on my PC through some external application?

Continuities commented 10 years ago

I suppose that's possible, but very odd. I don't think the issue is on the server, though, or everyone would be having this issue. I'll do some research next time I'm at my PC. On 27 Dec 2013 15:40, "mehbleh" notifications@github.com wrote:

Thanks for the quick reply. I've disabled all add-ons and cleared cache on Firefox, Chrome, and IE. Same garbled line appears. Might just be some problem on my PC through some external application?

— Reply to this email directly or view it on GitHubhttps://github.com/Continuities/adarkroom/issues/72#issuecomment-31279204 .

mehbleh commented 10 years ago

I sent a link to the game to a few friends and it worked fine for them. I also tried it on a sibling's laptop and it doesn't work on theirs. My sibling and I have similar add-ons for our browsers like NoScript (I disable it on A Dark Room), AdBlock Plus, and Ghostery etc. Though it doesn't really explain why it wouldn't work on IE which doesn't have those add-ons. I'm not sure what I can troubleshoot.

Thanks.

jernaumorat commented 10 years ago

There is definitely a Google Chrome extension attempting to modify the game's script. Chrome would not spit out an error message referencing jquery inside an extention otherwise; AdBlock Plus is the cause. Recently for me, ABP started generating javascript errors, due to a faulty update. Disable it, and report back.