doublesymmetry / KotlinAudio

KotlinAudio is an Android audio player written in Kotlin, making it simpler to work with audio playback from streams and files.
Apache License 2.0
45 stars 70 forks source link

[feat request] Square-crop Notification Albumart #79

Open lovegaoshi opened 1 year ago

lovegaoshi commented 1 year ago

I wonder if anyone else would find this issue helpful, or if devs are interested in implementing this/pulling my changes?

I unfortunately uses Samsung as my main phone and OneUI's android 13 doesnt have the new mediaSession notification style. What we got is the old school squared album art on the left, and metadata on the right. While I do try to keep all my album arts to be as square as possible, occasionally there are landscape or portrait album arts mixed in. The squared album art does a "contain" instead of "cover" so annoying white spaces will show. My solution is to crop any loading album art to squares: https://github.com/doublesymmetry/KotlinAudio/commit/c514071bde3636302eabbd51e6dfd50aa0bc87d3

Although is this a good idea to push a PR or better kept in my own repo?

Samsung's media notification looks like: https://www.reddit.com/r/oneui/comments/x46hbm/concept_one_ui_5_what_couldve_been_notifications/

dcvz commented 1 year ago

@lovegaoshi what do your changes look like on other devices using the new media session on other devices?

lovegaoshi commented 1 year ago

im using a 1280*720 pic https://i.ytimg.com/vi/5IOVkstxkdE/maxresdefault.jpg cropped pixel ->not cropped pixel -> cropped samsung -> not cropped samsung Untitled i guess its better to make it as an option... and very unfortunately oneUI6 still (partly) has this square notification