search

doublesymmetry / KotlinAudio

KotlinAudio is an Android audio player written in Kotlin, making it simpler to work with audio playback from streams and files.
Apache License 2.0
44 stars 70 forks source link

fix: notification controls flickering after calling updateOptions #82

Closed mvn-hungtruong-dn closed 1 year ago

mvn-hungtruong-dn commented 1 year ago

I only update the internalNotificationManager instead of re-initiating it again. It will make the buttons stop flickering. Please check this.

Related to this issue https://github.com/doublesymmetry/react-native-track-player/issues/1419

puckey commented 1 year ago

Thanks this looks very interesting – I will go through the pr in detail on Tuesday

kirillzyusko commented 1 year ago

@puckey just a friendly reminder - have you had a chance to review it?

puckey commented 1 year ago

Will hopefully do so in the coming week

puckey commented 1 year ago

I am unable to replicate the issue where controls are flickering.. Can you give me instructions how I can replicate this?

puckey commented 1 year ago

Ah sorry, I see the issue now.

mvn-hungtruong-dn commented 1 year ago

@puckey I rebased on top of your branch. Please merge PR #85 and check it again. Thanks. 😄

puckey commented 1 year ago

@puckey I rebased on top of your branch. Please merge PR #85 and check it again. Thanks. 😄

Looking really good - thank you! I have merged your pr into https://github.com/doublesymmetry/KotlinAudio/pull/85

dcvz commented 1 year ago

Merged in as part of #85. Thanks for your work here @mvn-hungtruong-dn!