chore: improve metadata handling - Githubissues

doublesymmetry / KotlinAudio

KotlinAudio is an Android audio player written in Kotlin, making it simpler to work with audio playback from streams and files.

Apache License 2.0

44 stars 70 forks source link

chore: improve metadata handling #85

Closed puckey closed 1 year ago

puckey commented 1 year ago

fix pixelated display of artwork (see https://github.com/doublesymmetry/react-native-track-player/issues/1934)
move MediaSource.getMediaMetadataCompat() extension to MediaItem.getAudioItemHolder()
introduce MediaItem.getAudioItemHolder() extension
throttle invalidate function directly
avoid unnecessary resetting of media metadata provider
fix unnecessary resetting of artwork bitmap in notificationMetadata setter
remove tail call of invalidate (unless someone can show it is needed)
remove PlayerConfig.androidNotificationThrottleInterval again
avoid flickering of notification when changing config by skipping recreation of notification manager when it is not necessary

puckey commented 1 year ago

I will be testing this pr tomorrow on various devices

puckey commented 1 year ago

Added some changes:

treat notification metadata bitmap as seperate from the one belonging to individual tracks
introduce notification metadata helpers to avoid duplication on somewhat complicated fallbacks from notification metadata to media metadata to item fields etc
inline getMediaMetadataCompat helper into NotificationManager
remove notificationMetadataFlow since it isn’t necessary
separate cache for now playing bitmap
when bitmap is loaded, call invalidate() in order to refire mediaSessionConnector.setMediaMetadataProvider and getCurrentLargeIcon callbacks
avoid lockscreen ui jumping when loading artwork by returning transparent placeholder image in getCurrentLargeIcon

Should be ready for review now..

puckey commented 1 year ago

I will be testing this pr tomorrow on various devices

(tested this briefly on 7 devices from android 7 to android 13..)

jspizziri commented 1 year ago

Thanks for doing this @puckey !

puckey commented 1 year ago

Merged in the following pr which fixes an issue where the controls were flickering when the notification was configured multiple times on older versions of Android: https://github.com/doublesymmetry/KotlinAudio/pull/82