doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.25k stars 1.01k forks source link

PlaybackProgressUpdated event dispatches different "buffer" property on Android and on IOS #2134

Closed czekFREE closed 1 year ago

czekFREE commented 1 year ago

Describe the Bug PlaybackProgressUpdated event dispatches different "buffer" property on Android and on IOS. On IOS event.buffered is being dispatched, on Android event.buffer is being dispatched. According to documentation only event.buffer should be dispatched - see https://rntp.dev/docs/next/api/events#playbackprogressupdated, but according to typings event.buffered should be dispatched (see https://github.com/doublesymmetry/react-native-track-player/blob/main/src/interfaces/events/PlaybackProgressUpdatedEvent.ts and https://github.com/doublesymmetry/react-native-track-player/blob/main/src/interfaces/Progress.ts)

Steps To Reproduce

Code To Reproduce

Replicable on Example App?

Environment Info: System: OS: macOS 13.5.2 CPU: (10) arm64 Apple M1 Pro Memory: 105.73 MB / 16.00 GB Shell: version: 3.2.57 path: /bin/bash Binaries: Node: version: 16.19.0 path: ~/.nvm/versions/node/v16.19.0/bin/node Yarn: Not Found npm: version: 8.19.3 path: ~/.nvm/versions/node/v16.19.0/bin/npm Watchman: version: 2023.05.01.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.11.3 path: /Users/jibeleck/.rbenv/shims/pod SDKs: iOS SDK: Platforms:

Paste the exact react-native-track-player version you are using "react-native-track-player": "4.0.0-rc08",

Real device? Or simulator? IOS tested on simulator, android on device

How I can Help If you want, I could help with that, but I would have to know what it the way how this should be fixed - I would guess to rename ios/android property to be consistent, I do not know which one + this might be considered dangerous / breaking change, so I do not know if you want that...

dcvz commented 1 year ago

Thanks for reporting @czekFREE! This has been fixed and will go out in the next RC