Closed AptypTheKing closed 9 months ago
@AptypTheKing please test this in the latest v4 RC. if it's still happening there I'll reopen.
@AptypTheKing please test this in the latest v4 RC. if it's still happening there I'll reopen.
Yes it is still happening
Will test in the nearest future
For me solved on last RC version
Hi all. What change fixed this issue?
@raymondjacobson update to the latest version
@AptypTheKing I am trying - but am seeing major issues that prevent a smooth upgrade from v3.2.0. Repeat no longer fires an event, etc. Is it possible to let me know what commit fixed this particular crash?
@raymondjacobson new version is better then old one. I strongly advice you to update. But if you really don't want, check the code and receivers export.
@raymondjacobson new version is better then old one. I strongly advice you to update. But if you really don't want, check the code and receivers export.
Is it this change? https://github.com/doublesymmetry/react-native-track-player/pull/2174/files
When trying to upgrade to v4--
Number 6 here https://rntp.dev/docs/v4-migration#general-deprecations
Event.PlaybackTrackChanged - Please use [Event.PlaybackActiveTrackChanged](https://rntp.dev/docs/api/events#playbackactivetrackchanged). Also note that in 4.0 Event.PlaybackTrackChanged is no longer emitted when a track repeats.
It seems that if repeat mode is set, no event from useTrackPlayerEvents
is fired at all when the active track ends. Is this a known bug?
Hi @raymondjacobson @AptypTheKing Did you found anything to fix this Android 14 Crash?
I am currently using Track Player version 3.2.0, and I prefer not to upgrade to the latest version due to the extensive changes required for migration.
Have you discovered any manual adjustments that can be made to resolve this issue? Your assistance would be greatly appreciated.
@mayank-paryani Hi, I don't have this crash since upgraded to the latest version. I also recommend you to upgrade if you don't have so much problems with dependencies.
@mayank-paryani Hi, I don't have this crash since upgraded to the latest version. I also recommend you to upgrade if you don't have so much problems with dependencies.
@AptypTheKing Thank you for your assistance. I've successfully upgraded to version 4.0.1, resolving the crash issue on Android 14. However, I encountered an issue with the TrackPlayer.reset() method post-upgrade. In certain instances, this method caused crashes on Android devices, prompting me to remove it from certain areas.
Describe the Bug When start playing the file, the app is crashing. This happened only Android 14. No logs in console, but the log in the logcat in Android Studio shows:
The playing audio appears in notification center, but nothing is playing cause the app is crashed. Looks like somewhere receiver export is missing, but cannot find where.
Steps To Reproduce Normal setup on Android 14
Code To Reproduce
Replicable on Example App? Can you replicate this bug in the React Native Track Player Example App?
Didn't try.
Environment Info: Paste the results of
npx react-native info
Paste the exactreact-native-track-player
version you are using Real device? Or simulator? What OS are you running?System: OS: macOS 13.0 CPU: (12) arm64 Apple M2 Pro Memory: 115.80 MB / 16.00 GB Shell: 5.8.1 - /bin/zsh Binaries: Node: 16.20.0 - /opt/homebrew/opt/node@16/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 8.19.4 - /opt/homebrew/opt/node@16/bin/npm Watchman: 2023.03.27.00 - /opt/homebrew/bin/watchman Managers: CocoaPods: 1.11.3 - /Users/mainuser/.rbenv/shims/pod SDKs: iOS SDK: Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1 Android SDK: Not Found IDEs: Android Studio: 2022.2 AI-222.4459.24.2221.9862592 Xcode: 14.1/14B47b - /usr/bin/xcodebuild Languages: Java: 11.0.18 - /usr/bin/javac npmPackages: @react-native-community/cli: Not Found react: 18.2.0 => 18.2.0 react-native: 0.71.13 => 0.71.13 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found
react-native-player version 3.2.0
Simulator Android Pixel 6 Api 34
How I can Help
Have you investigated the underlying JS or Swift/Android code causing this bug?
Looks like there is a problem with exoplayer2.
I think in this function should be context.RECEIVER_EXPORTED, but it's read-only