search

doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.2k stars 984 forks source link

fix: don't emit `PlaybackTrackChanged` along with `PlaybackQueueEnded` on Android #2161

Closed kirillzyusko closed 9 months ago

kirillzyusko commented 9 months ago

Fixes https://github.com/doublesymmetry/react-native-track-player/issues/2160

It seems like original changes were introduced in https://github.com/doublesymmetry/react-native-track-player/commit/5ba6c77ac125aef990b56b5a8a08f75a8e6f9a65

@dcvz do you remember why you've added this code? It doesn't contain any references to any issues, so wanted to check with you why it was needed 👀

dcvz commented 9 months ago

Thanks for this @kirillzyusko, such a long time ago I added this. I believe this was added because users wanted to have information about how much of the track was heard for analytics purposes.

Given that queue ending event also holds the position I think we can now remove this.