search

doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.18k stars 981 forks source link

feat: android media control notification naming customize #2182

Closed wn-na closed 8 months ago

wn-na commented 8 months ago

change to notification name & id for strings.xml

dcvz commented 8 months ago

Great addition @0xlethe! Allowing these to be modified by the end user is great.

I have two requests:

  1. let's prefix the keys with rntp_ to distinguish our uses and not pollute the global namespace.
  2. could you add a brief section in the docs to indicate to users that this is possible? https://rntp.dev/docs/next/basics/playback-service
wn-na commented 8 months ago

@dcvz sure, i fixed two of your requests. Please check them out