Open uzegonemad opened 5 months ago
Describe the Bug When setting minBuffer, an error is thrown about maxBuffer, even if minBuffer is less than the maxBuffer default.
Exception: The value for maxBuffer should be greater than or equal to minBuffer.
The value for maxBuffer should be greater than or equal to minBuffer.
According to the docs, maxBuffer defaults to 50, so anything < 50 shouldn't trigger this error.
Steps To Reproduce Call setupPlayer with a minBuffer of <50.
setupPlayer
Code To Reproduce
TrackPlayer.setupPlayer({ minBuffer: 5 });
Replicable on Example App? Haven't tried
Environment Info: Paste the results of npx react-native info
npx react-native info
System: OS: macOS 14.2.1 CPU: (10) arm64 Apple M1 Max Memory: 86.11 MB / 32.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 18.19.0 path: ~/.nvm/versions/node/v18.19.0/bin/node Yarn: version: 1.22.21 path: ~/.nvm/versions/node/v18.19.0/bin/yarn npm: version: 10.2.3 path: ~/.nvm/versions/node/v18.19.0/bin/npm Watchman: version: 2023.11.20.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.14.3 path: /Users/benjamin/.rbenv/shims/pod SDKs: iOS SDK: Not Found Android SDK: Not Found IDEs: Android Studio: 2022.3 AI-223.8836.35.2231.10671973 Xcode: version: /undefined path: /usr/bin/xcodebuild Languages: Java: version: 17.0.8.1 path: /usr/bin/javac Ruby: version: 2.7.7 path: /Users/benjamin/.rbenv/shims/ruby npmPackages: "@react-native-community/cli": Not Found react: installed: 18.2.0 wanted: 18.2.0 react-native: installed: 0.73.2 wanted: 0.73.2 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: false iOS: hermesEnabled: true newArchEnabled: false
Paste the exact react-native-track-player version you are using react-native-track-player ^4.0.1
react-native-track-player
Real device? Or simulator? Both
How I can Help Not sure. At first glance, the code seems to be fine.
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Still relevant
Describe the Bug When setting minBuffer, an error is thrown about maxBuffer, even if minBuffer is less than the maxBuffer default.
Exception:
The value for maxBuffer should be greater than or equal to minBuffer.
According to the docs, maxBuffer defaults to 50, so anything < 50 shouldn't trigger this error.
Steps To Reproduce Call
setupPlayer
with a minBuffer of <50.Code To Reproduce
Replicable on Example App? Haven't tried
Environment Info: Paste the results of
npx react-native info
Paste the exact
react-native-track-player
version you are using react-native-track-player ^4.0.1Real device? Or simulator? Both
How I can Help Not sure. At first glance, the code seems to be fine.