Closed tomislav-arambasic closed 3 months ago
Thanks for taking the time @tomislav-arambasic ! As you saw there's been some conversation on the other thread around options and possibilities.
I'll review this PR later this week!
Sorry for the delay here! I'm hoping to go through this soon
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity.
@dcvz Not rushing anything, I've just noticed it got auto-closed and I thought you might be interested in feature :)
Summary
Resolves https://github.com/doublesymmetry/react-native-track-player/issues/2158.
Added
nowPlayingMetadata
hook,getNowPlayingMetadata
getter andNowPlayingMetadataChanged
event. Reflect these changes inupdateMetadataForTrack
(when it's the active track) andclearNowPlayingMetadata
for time before deprecation.useActiveTrack()
stays intact, as David suggested in issue, I've done changes as per his recommendations, implementing new event, getter and hook, independently ofuseActiveTrack
.activeTrack
event, getter and hook do not provide now playing metadata information - if users would ever change metadata of track that is currently playing, there would be no update to itMetadataTimedReceived
event is emitted. But, if user would unmount the screen and then come back to it, now playing metadata is not accessible, until newMetadataTimedReceived
event is emitted - when song on the radio stream changesHow it works
updateNowPlayingMetadata
, orupdateMetadataForTrack
, if it's active track, is called, new metadata is saved into private var insideMusicService
/RNTrackPlayer
andNowPlayingMetadataChanged
event is emitted.clearNowPlayingMetadata
reflects these changes accordingly, until it'll be deprecated as announcedgetNowPlayingMetadata
returns that variable's value, last stored metadatauseNowPlayingMetadata
fetches that variable's value on mount, saves it into state. Every timeNowPlayingMetadataChanged
is emitted, it updates the internal state with new metadata. Hook returns metadataNowPlayingMetadataChanged
is subscribable, event returnsmetadata
objectTesting
Screenshots
Note that artwork gets updated randomly, and because notification metadata and our
nowPlayingMetadata
update at at different time, they're not the same.Note
@dcvz I've just noticed that notification metadata is "patched", instead of replaced. E.g., if we update now playing metadata, or metadata for active track, it'll keep old metadata values for any undefined values in object we're updating with. I'm not sure if this should be the case, I'd expect users to be able to override notification data completely.
nowPlayingMetadata
is replaced completely with new values, even if they're undefined.