search

doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.18k stars 981 forks source link

[Documentation] v4 Docs remove() references tracks instead of indices #2262

Open uzegonemad opened 4 months ago

uzegonemad commented 4 months ago

The docs currently state that the remove() method expects a Track(s). It actually expects an index/indices, and passing tracks will crash the app (at least on iOS).

Note: I haven't confirmed if any other methods in the docs are also outdated.

krestaino commented 3 months ago

I can confirm the same on Android. I didn't know if it was a bug or simply the docs needed to be updated, but since it's like this on iOS and this looks like code for Android, I'm assuming the docs just need to be updated.

github-actions[bot] commented 1 day ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.