search

doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.18k stars 981 forks source link

[administrative] maintenance status #2340

Closed lovegaoshi closed 3 days ago

lovegaoshi commented 4 days ago

hi!

this is a maintenance status request to the lib collaborators/maintenance team @dcvz @jspizziri @puckey. RNTP hasnt seen a major maintenance effort in a couple of months. I'm currently following the new arch fix for RNTP and a bunch of other libraries related to HeadlessJsTask (https://github.com/facebook/react-native/issues/44255) and the fb team expressed a similar concern that this lib is not maintained. I understand everyone is busy and I still see myself being active in the RN community since my app using RNTP is actively maintained, so Im volunteering to maintain the android part of RNTP to make the library alive and give fb some confidence to not deprecate HeadlessJs, if necessary. I've worked on some bug fixes and the android auto FR, fade effect FR and crossfade FR here. thanks!

jspizziri commented 4 days ago

Hi @lovegaoshi ,

I use this library in production and I'm pretty sure @puckey does too. Regarding a lack of maintenance effort over the last couple of months: largely I'd say this is due (at least from my perspective) to things being pretty stable. I've got some work on the back burner regarding better web support, but it hasn't been critical for me to get across the finish line.

I've been keeping an eye on your work and am very grateful for all the energy and effort you've put into the library! Regarding wanting to help maintain the android side, I'd say all of us would be super on board with contributions. I think most of your work has been on Android auto to this point and, as a result not much has been merged due to reasons we've already chatted about on other issues (largely the hard fork of HeadlessJS).

At a high-level here are my thoughts on contribution:

  1. Bug fixes for Android are super welcome. I've we haven't been on the ball with that I apologize. Just ping me as to what things have slipped through the cracks and I can work with you on them.
  2. Enhancements are an interesting area, as a primary concern is feature parity across all platforms. I realize that you largely only care about Android, but the fundamental nature of RNTP is a cross-platform and consistent experience (as much as that's possible. That said, while all the features you mentioned are super interesting, having a serious discussion about them in an "Android Only" context is a hard sell (at least for me).

Regarding keeping this library alive. I certainly intend to keep it alive as much as I'm able given that I'm currently using it in several production deployments.

Does that help at all or answer your questions?

dcvz commented 3 days ago

Hey @lovegaoshi,

The library is not dead or completely unmaintained. Although it’s not as active as we might like, it’s stable and actively used in production by the team members. Due to personal responsibilities, I haven’t been able to focus on delivering new code, but I keep an eye on significant issues. We welcome and appreciate contributions.

Currently, my biggest constraint is time, as I juggle personal and family responsibilities. If you’re interested in helping advance the library, addressing reported issues and facilitating PR reviews would be immensely helpful. While your PRs adding new functionality are great (and we've discussed some of them), assisting with existing PRs, testing, providing feedback, and engaging the team on crucial bits would have a significant impact.

If you have specific ideas or features you’d like to work on, please create issues to discuss them. We’ll try to ensure they align with the library’s goals and provide guidance. I do my best to respond to pings and schedule reviews.

The maintenance team is open to contributors who have a history of improving the library, and I’m happy to extend the role to those individuals.

Hope this answers your query!

lovegaoshi commented 3 days ago

appreicate the fast response, I hope this is enough for fb to consider resolving the new arch headlessJs issue on a priority. in the meantime if I can draw attention to this PR from the expo team (https://github.com/doublesymmetry/react-native-track-player/pull/2290) it is very appreciated. thank you for the work as always.