search

doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.3k stars 1.02k forks source link

Crash with RN 76. New architecture support #2389

Open masarbazi opened 2 weeks ago

masarbazi commented 2 weeks ago

Describe the Bug App crashes with RN76 where new arch is enabled by default. image

Steps To Reproduce Create new RN app and there we go...

Code To Reproduce Just import TrackPlayer from 'react-native-track-player'; will cause the error

Environment Info:

Track player version:
  "react-native-track-player": "^4.1.1"
System:
  OS: Windows 11 10.0.22631
  CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-12650H
  Memory: 14.01 GB / 31.73 GB
npm:
    version: 10.2.4
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    Android NDK: 23.1.7779620
  Windows SDK: Not Found
IDEs:
  Android Studio: AI-223.8836.35.2231.10406996
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.12
    path: /c/Program Files/Common Files/Oracle/Java/javapath/javac
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 15.0.0
    wanted: 15.0.0
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.1
    wanted: 0.76.1
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
danishhusain commented 2 weeks ago

WhatsApp Image 2024-11-04 at 16 49 39

I am also facing issue in New architecture. Team please fix the issue and its very important for us.

@egorkhmelev @qmx @skahack

danishhusain commented 2 weeks ago

Describe the Bug App crashes with RN76 where new arch is enabled by default. image

Steps To Reproduce Create new RN app and there we go...

Code To Reproduce Just import TrackPlayer from 'react-native-track-player'; will cause the error

Environment Info:

Track player version:
  "react-native-track-player": "^4.1.1"
System:
  OS: Windows 11 10.0.22631
  CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-12650H
  Memory: 14.01 GB / 31.73 GB
npm:
    version: 10.2.4
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    Android NDK: 23.1.7779620
  Windows SDK: Not Found
IDEs:
  Android Studio: AI-223.8836.35.2231.10406996
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.12
    path: /c/Program Files/Common Files/Oracle/Java/javapath/javac
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 15.0.0
    wanted: 15.0.0
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.1
    wanted: 0.76.1
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

If you found any solution please ping me.

pigeonmal commented 2 weeks ago

look at https://github.com/doublesymmetry/react-native-track-player/pull/2370

smfunder commented 1 week ago

I'm also here because I'm facing this issue with 4.1.1 and RN 0.76.1 with New Arch enabled. I will be investigating and report any news.

kesha-antonov commented 1 week ago

Hi Same error here

oraylan commented 1 week ago

Hi, I have the same error here w/ 4.1.1 and RN 0.76.1.

Obviously I need to disable the new architecture to make it work.

baselshlewett commented 1 week ago

How can we help to make this library support the new arch?

kesha-antonov commented 1 week ago

How can we help to make this library support the new arch?

Try this PR At least app builds with it

https://github.com/doublesymmetry/react-native-track-player/pull/2290

gh-pro commented 5 days ago

Thanks i have tested and its works

How can we help to make this library support the new arch?

Try this PR At least app builds with it

2290

Thanks, i have tested and its work.