search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

Do not email members waiting on scholarship to finish setup / set up dues #346

Open compwron opened 5 years ago

compwron commented 5 years ago

From https://github.com/doubleunion/arooo/issues/292

Differentiate between "haven't set up dues yet" and "waiting on scholarship" so that if someone is waiting for scholarship setup, the webapp doesn't email them saying "hey please finish your setup!" (or we can add text to that reminder email saying "unless you're waiting for a scholarship, in which case you're all good and you'll hear from the board in the next two weeks) reminder emails: https://github.com/doubleunion/arooo/tree/master/app/views/new_members_mailer

brittag commented 3 years ago

Agree with this!

I wrote some text changes for the email reminders at https://github.com/doubleunion/arooo/pull/527 to reduce that confusion, but really we shouldn't email people at all if (1) they have a Google-friendly email on file, (2) they haven't set up their dues, (3) they have submitted a request for a scholarship.

This is related to https://github.com/doubleunion/arooo/issues/468 - we would need to track which membership have applied for scholarships.