search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

Ask for Google-friendly email upfront during the application process #487

Closed brittag closed 2 years ago

brittag commented 4 years ago

Right now, after a member is accepted, they need to do two things: add in their google-friendly email address and set up their dues or a scholarship. This is a hassle for membership coordinators because they need to remind people to set up their Google-friendly email, sometimes even after the person has set up their dues.

This means we should ask for Google-friendly email upfront during the application process instead of after they apply, so that the post-application process is simplified:

  1. People add their dues or apply for a scholarship
  2. The membership coordinator uses the existing Google-friendly email on file to set up the person's access to things
brittag commented 3 years ago

This should also resolve most of the issue at https://github.com/doubleunion/arooo/issues/339

brittag commented 3 years ago

Also, if an applicant logs in using Google authentication, can we automatically get a good Google-friendly email address for them? If so, I believe we should auto-fill their "Google-friendly email" with their Google account info. They can review and update it while filling out their application.

I figure this shouldn't be a required field, in case somebody really wants to join without a Google address.

brittag commented 3 years ago

If/when we do this, we'll need to update the text of these automated email reminders again: https://github.com/doubleunion/arooo/pull/527

brittag commented 3 years ago

Example copy for the membership application (might not fit well - just an example of the idea):

Contact email: [ ] Google account email (if different from contact email): [ ] We use Google Drive and Google Calendar for internal coordination for members, so this helps us add you to these resources if you get accepted as a member.

sarahwalters commented 2 years ago

Is it alright if I work on this issue? Started experimenting and I think I see how to make this change. I think I'm not able to assign the issue to myself since I'm not a collaborator in the repo.

I also noticed some minor inconsistencies on the application edit and show pages (e.g. on the edit page "required" is not in parentheses but "optional" is; e.g. not all fields on the show page are marked as "required" or "optional"). Is it okay to attach two PRs to this issue, one PR to clean up those minor inconsistencies and another PR to add the feature -- or would it be better to create a separate issue for the cleanups?

anaulin commented 2 years ago

@sarahwalters yes, please and thank you! I have assigned this issue to you.

It is fine to attach multiple PRs to this issue, or just do small clean-up PRs without a specific issue. (Our current PR load is so small that we can afford not to be picky about keeping things extra-tidy.)

I also sent you an invitation to join the DU org so that you can have some basic write permissions in this repo (e.g. you don't have to work from a fork if you don't want to, and you should be able to self-assign issues if you'd like).