doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

If a new member has applied for a scholarship, they shouldn't get dues setup reminder emails #528

Closed brittag closed 3 years ago

brittag commented 3 years ago

Currently if a new member applies for a dues scholarship and is waiting to hear back about it, the Arooo system doesn't know that they're waiting on something (they look like they just haven't finished setting up their account), so they keep getting confusing email reminders about setting up their account.

I wrote some text changes for the email reminders at https://github.com/doubleunion/arooo/pull/527 to reduce that confusion, but really we shouldn't email people at all if (1) they have a Google-friendly email on file, (2) they haven't set up their dues, (3) they have submitted a request for a scholarship.

This is related to https://github.com/doubleunion/arooo/issues/468 - we would need to track which membership have applied for scholarships.

brittag commented 3 years ago

Closing as a duplicate of https://github.com/doubleunion/arooo/issues/346