search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

Remove configurable for orientation signup link. #762

Closed sarahwalters closed 1 year ago

sarahwalters commented 1 year ago

What github issue is this PR for, if any?

None -- discussed during the virtual membership committee meeting today, and did not file an issue.

What does this code do, and why?

We have a rolling application process now, so we won't do one batch of orientations all at once that all new members should sign up for. I think it would be hard to keep an orientation signup page up to date as new members apply throughout the year, and it would probably be easier to have the membership coordinator handle scheduling orientations for new members as needed.

How is this code tested?

Unit tests.

Also ran the code in my local environment, but I think the local environment doesn't actually send emails. When I approve an application, the server logs that it's sending an email and logs the contents of the email to the console (screenshot below), but no email is actually sent.

Are any database migrations required by this change?

No

Are there any configuration or environment changes needed?

No

Screenshots please :)

Screenshot of the email that was logged to the console when I approved an application (with HTML formatting, it should look nicer in people's inboxes): Screenshot 2023-02-01 9 34 05 PM

sarahwalters commented 1 year ago

The brakeman check failed with "EOLRuby: Support for Ruby 2.7.6 ends on 2023-03-31". It looks like @Imperiopolis just upgraded from 2.7.1 to 2.7.6 last week. I'm not sure if the failing check blocks merging this PR or not.

Imperiopolis commented 1 year ago

The brakeman check failed with "EOLRuby: Support for Ruby 2.7.6 ends on 2023-03-31". It looks like @Imperiopolis just upgraded from 2.7.1 to 2.7.6 last week. I'm not sure if the failing check blocks merging this PR or not.

We should probably upgrade to a more modern ruby soon, but that was a larger task. It should be safe to ignore that error.

anaulin commented 1 year ago

@sarahwalters that particular brakeman warning is now silenced. If you rebase on the latest main, your PRs should go green.

sarahwalters commented 1 year ago

Rebased on the latest main and the checks are all green -- thank you!