search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

Change handbook link on members homepage to key code orientation link. #763

Closed sarahwalters closed 1 year ago

sarahwalters commented 1 year ago

What github issue is this PR for, if any?

Didn't file an issue.

What does this code do, and why?

Change the handbook link on members homepage to the key code orientation link.

Discussed during the membership committee meeting on 2/1/23. The handbook is very long, and probably what most people need to know is how to get into the DU space. The key code orientation slide deck explains how to get into the DU space more concisely.

How is this code tested?

Locally -- screenshot below. No unit tests needed because this is just a text change.

Are any database migrations required by this change?

No

Are there any configuration or environment changes needed?

No

Screenshots please :)

Screenshot 2023-02-01 10 04 00 PM

I tried the new "Key code orientation" link to make sure it goes to the right place.

sarahwalters commented 1 year ago

Same as https://github.com/doubleunion/arooo/pull/762 -- it looks like the brakeman check is failing because the current Ruby version (2.7.6) is nearing end of life. I'm not sure if the failing check blocks merging this PR or not.

sarahwalters commented 1 year ago

The failing check was fixed on main -- rebased past that change and these checks are passing now.