search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

Explain how to update card on file without changing dues amount. #764

Closed sarahwalters closed 1 year ago

sarahwalters commented 1 year ago

What github issue is this PR for, if any?

Didn't file an issue

What does this code do, and why?

Add a sentence to explain how members can update their card on file with Stripe without changing their dues amount.

A member reached out to the membership@ email address asking how to update their card without changing the dues amount. I think it's a bit unclear in the app -- it looks like the "Update Dues" button is only for changing the dues amount.

How is this code tested?

Locally -- screenshot below. No unit tests needed because this is just a text change.

Are any database migrations required by this change?

No

Are there any configuration or environment changes needed?

No

Screenshots please :)

Screenshot 2023-02-01 10 25 06 PM

sarahwalters commented 1 year ago

Same as https://github.com/doubleunion/arooo/pull/762 -- it looks like the brakeman check is failing because the current Ruby version (2.7.6) is nearing end of life. I'm not sure if the failing check blocks merging this PR or not.

sarahwalters commented 1 year ago

The failing check was fixed on main -- rebased past that change and these checks are passing now.