search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

added controller specs #772

Closed fchatterji closed 1 year ago

fchatterji commented 1 year ago

What github issue is this PR for, if any?

Resolves #453

What does this code do, and why?

added some specs for comments controller added specs to the admin controller removed duplicated simplecov config in rails bin improved simplecov config in spec helper to add coverage groups (models, controllers...)

How is this code tested?

Are any database migrations required by this change?

no

Are there any configuration or environment changes needed?

no

Screenshots please :)

fchatterji commented 1 year ago

@compwron I fixed the failing tests

fchatterji commented 1 year ago

@compwron I had more time on this, so I improved the tests for the admin controller. Please tell me if that looks good to you, if it does i propose merging this PR, and when i have time i'll do another one for the other controllers