search

doubleunion / arooo

Membership management for hacker/makerspaces
GNU General Public License v3.0
66 stars 55 forks source link

Former members get an error when they try to apply #783

Open brittag opened 1 year ago

brittag commented 1 year ago

What is the problem, and what should happen instead?

When a former member tries to make a new application, they get an error message instead:

Application not submitted: State cannot transition via “submit”

We should allow them to apply again, because former members are welcome! Currently we have to mess with the database as a workaround.

Notes on previous similar issue, from @anaulin: https://github.com/doubleunion/arooo/issues/317

If we want to allow former members and reject members to re-apply via the standard application system, we'll need to tweak the allowed state transitions. If we do this, we might want to think about a way to keep track of certain "previous states", e.g. if someone goes from former member to applicant, it would be nice to keep track in the database of the fact they used to be a member (maybe this is a new column on the users table that records previous states).

Screenshots of current behavior, if any

ItsElaineTime commented 1 year ago

Is there any metadata in particular we want to preserve about a member's former member status? Dates, a field for tracking why they left, etc? Or is it just a boolean flag that tracks whether a user was ever a member?

brittag commented 1 year ago

I think just a boolean flag is good! We don't need to track dates or other info.