douchunrong / flot

Automatically exported from code.google.com/p/flot
0 stars 0 forks source link

Flot uses tables for layout without ensuring reset/overriding of default styles. #95

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Specify a default table style for the site (say, margins, padding,
border collapse, borders etc - typical stuff)
2. Try creating a float graph with a label.

What is the expected output? What do you see instead?
Screwed up graph due to poor label styling.

Please provide any additional information below.

The workaround is to add extra styling for Flot's labels - what Flot should
be doing instead is resetting its styles and specifying them explicitly to
avoid default style issues.  Flot probably shouldn't be using a table there
either, but that's another matter.

Original issue reported on code.google.com by kyberneticist@gmail.com on 6 Jan 2009 at 8:05

GoogleCodeExporter commented 9 years ago
Actually, this is somewhat on purpose. If I hardcode the styles into the table, 
you
won't be able to override them with CSS. If you can find a way to keep this 
property,
without borking up on your use case, I'm all ears.

Original comment by olau%iol...@gtempaccount.com on 9 Jan 2009 at 4:39

GoogleCodeExporter commented 9 years ago
If anyone feels like coming up with a patch, I think the easiest way around 
this is
to replace the table with styling with divs as kyberneticist suggests. The code 
is in
insertLegend, it could be a fun little job. :)

Original comment by olau%iol...@gtempaccount.com on 13 Jan 2009 at 12:58

GoogleCodeExporter commented 9 years ago
I'm going to classify it as an enhancement for now.

Original comment by olau%iol...@gtempaccount.com on 20 Feb 2009 at 3:22

GoogleCodeExporter commented 9 years ago

Original comment by dnsch...@gmail.com on 8 May 2012 at 12:10