doudar / SmartSpin2k

Transform your spin bike into a Smart Trainer!
GNU General Public License v2.0
175 stars 33 forks source link

[FR] In the Settings page, make 'Reset to Defaults' only reset the values, and add a 'Factory Reset' to support current functionality #512

Open JulienCote opened 6 months ago

JulienCote commented 6 months ago

Is your feature request related to a problem? Please describe. I messed up my settings and clicked on the button hoping it would just put me back into the initial state. But it put me in a state where I had to set my local wifi to go back into an operable state. The problem is mostly UX based as I don't think that this is the instinctive behaviour for that button.

Describe the solution you'd like I would want the default values be put into the settings, and add a new "factory reset" button to preserve the current functionality.

Additional context I'm making a feature request to track my ask, but I can handle implementing the solution for this

doudar commented 6 months ago

Thanks for the tracking issue!

Btw, I don't believe the "scan to connect" shifter button holding feature is required anymore and could be deprecated. The new firmwares are constantly scanning if a connection isn't completed or drops. Possibly it could be repurposed to a reboot?