doudz / zigate

python lib for zigate
MIT License
46 stars 22 forks source link

Improve admin panel index #160

Closed pdecat closed 4 years ago

pdecat commented 4 years ago

This PR improves the presentation of the admin panel index view.

image

The devices table has a new column group and devices in the same group are displayed along side.

TODO:

doudz commented 4 years ago

Looks good to me, are you ready to merge ?

pdecat commented 4 years ago

I thought about removing the Groups table that I kept for debugging, do you agree?

doudz commented 4 years ago

Hum, how will it works when a device is in 2 groups ? (For example zigate itself support 5 groups)

pdecat commented 4 years ago

It will appear in each group.

doudz commented 4 years ago

Ok, it can be confusing but why not

ruimarinho commented 4 years ago

@doudz can we show friendly_name if available instead of manufacture device name? Not sure if we can plug anything from HASS here.. the previous network map used to show that successfully when it was used as a custom panel.

doudz commented 4 years ago

@doudz can we show friendly_name if available instead of manufacture device name? Not sure if we can plug anything from HASS here.. the previous network map used to show that successfully when it was used as a custom panel.

No chance yet, since the admin panel is not linked to HASS, sorry. But it could be done by setting some kind of handler to allow admin panel to fetch external data

doudz commented 4 years ago

Many thanks @pdecat