search

doudz / zigate

python lib for zigate
MIT License
46 stars 22 forks source link

Optionnal address mode argument to action_onoff #83

Closed Jsl-1 closed 5 years ago

Jsl-1 commented 5 years ago

Hi @doudz, Would it be possible to add address mode as optionnal argument to action_onoff method in core.py ? I ask because i need to call action_onoff for group address. I have tested with raw command and it's working great.

doudz commented 5 years ago

It's possible, but I have an other suggestion. Since the group address is supposed to be known maybe I could just choose the right address mode depending of the presence of the address in group list ? or I can do both, provide optionnal adress mode argument and if not specified, try to choose the right one

Jsl-1 commented 5 years ago

It would be great 👍 I can add command in home assistant when it's done if you want ;)

doudz commented 5 years ago

I just made a commit in dev, could you try ?

Jsl-1 commented 5 years ago

It's working great

Jsl-1 commented 5 years ago

Sorry to be late, i had to try from home assistant (and create new command) because i'm not alone at home ;) Thank you very much !