doug-m / CollectorAuroraTesting

Manage testing feedback for Collector holistic testing.
0 stars 7 forks source link

Ability to add vertex to line feature #248

Open ratliffk opened 4 years ago

ratliffk commented 4 years ago

Issue

Ability to add vertex to line feature

Expected Behavior

Going to break this into a couple issue threads. If snapping can only be accomplished to a vertex, need the ability to add a vertex to a line (i.e. - water main). It appears from the issues that a vertex can be added to a polygon. Regardless of the snapping to vertex, need ability to add a vertex to make adjustments to a line feature.

Map and Credentials

Steps to Reproduce

Create a line feature. Add a point (hydrant) at end. Need to add another point before (valve). No snapping available for valve if didn't had a vertex before end point.

Device Information

kyliedonia commented 4 years ago

You can insert a vertex today:

  1. While editing, tap the vertex you want to come before your new vertex to select it (it will show with a white fill).
  2. Tap add point to insert a point into the line at the crosshairs. It will follow your selected vertex.

See Edit location in the Collector doc on data capture.

ratliffk commented 4 years ago

Will give that a shot! Will advise if I'm not getting there. Thanks!!

ratliffk commented 4 years ago

Tried to walk through the instructions. (I'm not the best in conveying things sometimes in writing!) I'm not adding a vertex to the end of the line for extending. I'm trying to add a vertex into the existing line prior to the last vertex. In doing what you describe, I'm only doubling back up the line. Does that make sense?

colinlawr commented 4 years ago

I understand what you are explaining. You can add vertices to any point of the line, but you are actually modifying the line geometry and not simply adding a vertex so there is a chance you will slightly modify the line geometry in the process. So it is possible, but there are certainly things to discuss still.

I created a video of the workflow: https://www.screencast.com/t/CTZwfTMIu

kyliedonia commented 4 years ago

@ratliffk could you confirm if what Colin's video shows is what you are seeing? You are adding a vertex by placing a new vertex into the line with my steps (so you might change the line as it was between the other two vertices). But the link doesn't get doubled -- it is updating the earlier section of the line, changing the geometry based on the new vertex. If you are seeing additional line get created on top of the other parts, you need to make sure you have the correct selected (white) vertex.

ratliffk commented 4 years ago

Currently the only way to snap a new point feature is having a vertex to snap too. In the attached video, I’m trying to add a valve point to an existing line with a hydrant at the end. When the line was originally drawn, a vertex was not in place. I’m trying to add a vertex to snap too. When I add the new vertex, that has now become my active vertex to draw from in the future. It didn’t insert a vertex in the line. (Part of the concern is if I total the length of mains, there will be more distance than there really is.) You can see in the video, if I miss the existing line with the vertex, then add a valve, a flow model will have the valve after the hydrant, not before.

(Ssooo...Github apparently doesn’t support adding a video capture from an iPad...is there a way to get the video to you?)