search

dougal / acts_as_indexed

Acts As Indexed is a plugin which provides a pain-free way to add fulltext search to your Ruby on Rails app
http://douglasfshearer.com/blog/rails-plugin-acts_as_indexed
MIT License
211 stars 49 forks source link

Ensure that thread is required when using Mutex on Ruby 1.8.7 #43

Closed parndt closed 11 years ago

parndt commented 11 years ago

This used to be loaded by, I believe, Rake but not anymore.

My tests were failing only on Ruby 1.8.7: https://travis-ci.org/refinery/refinerycms-acts-as-indexed/jobs/4297230/#L139

parndt commented 11 years ago

The failing test on your build seems like a CI glitch: https://travis-ci.org/dougal/acts_as_indexed/jobs/4297613

After my patch my project's tests pass: https://travis-ci.org/refinery/refinerycms-acts-as-indexed/jobs/4297668

dougal commented 11 years ago

There was a whole bunch of 1.8.7 glitches I had to deal with on CI. Have merged this fix to the development branch, thanks.

parndt commented 11 years ago

Thanks, this is affecting (my) third party libraries too so hopefully this goes into a released version in the near future :+1:

dougal commented 11 years ago

Friday for the next release, assuming nothing blocking comes up.