dougal / acts_as_indexed

Acts As Indexed is a plugin which provides a pain-free way to add fulltext search to your Ruby on Rails app
http://douglasfshearer.com/blog/rails-plugin-acts_as_indexed
MIT License
211 stars 49 forks source link

Change Fixnum test to Integer #62

Closed yez closed 1 year ago

yez commented 6 years ago

Fixes #61

When updating to Ruby 2.5, Fixnum has been deprecated and eventually removed.

Some formatting was also off and I fixed that.

I also suggest outside of this PR to add more versions to .travis.yml

yez commented 6 years ago

Build failures seem unrelated to this change.

randallreedjr commented 5 years ago

@yez Thanks for the fix!

yez commented 5 years ago

@randallreedjr happy to contribute. I'm not able to restart that Travis build so let me know if these failures are legitimate and I can help more.

ryankopf commented 1 year ago

Going to merge this next week, trying to see if I can get the workflow working and test this again before merging, but the change seems trivial.

ryankopf commented 1 year ago

Update: Going to merge after I merge my test-workflow branch to get testing and Github actions going.