search

dougallj / applegpu

Apple G13 GPU architecture docs and tools
BSD 3-Clause "New" or "Revised" License
545 stars 40 forks source link

Add `offset_` prefix to the names in the Ou enum #34

Open dougallj opened 1 year ago

dougallj commented 1 year ago

Just saying unsigned or signed is ambiguous, so this attempts to clarify that it refers to whether the offset is signed or unsigned extended from 32-bit to 64-bit before adding it to the address.

alyssarosenzweig commented 1 year ago

it might be more consistent with ALU to put a .sx source modifier on the offset when signed-extended (and nothing for not)? I really need to RiIR the disassembler ngl

dougallj commented 1 year ago

Ah, good point, yeah, I don't know why I didn't think of that.