search

dougbinks / enkiTS

A permissively licensed C and C++ Task Scheduler for creating parallel programs. Requires C++11 support.
zlib License
1.66k stars 138 forks source link

CMake version #124

Closed erincatto closed 2 months ago

erincatto commented 2 months ago

I'm seeing this all the time lately using enkiTS via CMake.

CMake Deprecation Warning at build/_deps/enkits-src/CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future version of CMake.

Update the VERSION argument value or use a ... suffix to tell CMake that the project does not need compatibility with older versions.

It would helpful to bump the version to 3.5. I tested this and it seems fine. I'd submit a PR, but it is a one line change.

dougbinks commented 2 months ago

Thanks for this issue report - I'm happy to receive a PR if you want your name in the commit log, but I'm equally happy just to make the change myself.

erincatto commented 2 months ago

See #126