search

dougbinks / enkiTS

A permissively licensed C and C++ Task Scheduler for creating parallel programs. Requires C++11 support.
zlib License
1.74k stars 145 forks source link

Sanitizer fixes #127

Closed erincatto closed 5 months ago

erincatto commented 5 months ago

CMake option ENKITS_SANITIZE Added ENKITS_SANITIZE to workflow static builds

Later it would be good to hookup thread sanitizer as well.

There was a problem getting the Windows runner to find the asan dll. I found a fix here: https://github.com/actions/runner-images/issues/8891

dougbinks commented 5 months ago

I'll look into this shortly - the CMake and actions changes add a few extra things to review so it will take a bit of time.

Note that thread sanitizer currently throws up some false reports when in the tests, so I don't want to add it to the github actions. I could reconfigure the test so these false reports don't get triggered, but that will take a bit of time which I don't currently have.

dougbinks commented 5 months ago

Merged, thanks once again!

erincatto commented 5 months ago

Thanks! I'll look into thread sanitizer more later.